Attachment 10161 Details for Bug 10728 – tiny regression test

[patch] tiny regression test

0001-s3-test_net_misc-regression-test-for-bso10728-segv.patch (text/plain), 1.06 KB, created by David Disseldorp on 2014-07-30 10:07:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Disseldorp

Created: 2014-07-30 10:07:19 UTC

Size: 1.06 KB

patch

obsolete

>From f2f9b53d06b531259e75a71650ff41ca2f378a7d Mon Sep 17 00:00:00 2001
>From: David Disseldorp <ddiss@samba.org>
>Date: Wed, 30 Jul 2014 11:23:29 +0200
>Subject: [PATCH] s3/test_net_misc: regression test for bso10728 segv
>
>Run "net time system" without providing a -S server argument. This
>should return 0 with usage information.
>
>Signed-off-by: David Disseldorp <ddiss@samba.org>
>---
> source3/script/tests/test_net_misc.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/source3/script/tests/test_net_misc.sh b/source3/script/tests/test_net_misc.sh
>index 566694b..5af9012 100755
>--- a/source3/script/tests/test_net_misc.sh
>+++ b/source3/script/tests/test_net_misc.sh
>@@ -50,6 +50,12 @@ testit "get the time zone" \
> 	test_time zone || \
> 	failed=`expr $failed + 1`
> 
>+# regression test for bso10728: 'net time system' segfaults
>+# net time currently returns 0 for invalid parameter errors.
>+testit "invalid time parameters" \
>+	${NETTIME} system ${SERVER} || \
>+	failed=`expr $failed + 1`
>+
> testit "lookup the PDC" \
> 	test_lookup pdc || \
> 	failed=`expr $failed + 1`
>-- 
>1.8.4.5
>

Actions: View

Attachments on bug 10728: 10159 | 10161