Attachment 10155 Details for Bug 10742 – Code fix

[patch] Code fix

0001-s4-rpc-dnsserver-Allow-.-to-be-specified-for-record.patch (text/plain), 1.23 KB, created by Amitay Isaacs on 2014-07-29 07:43:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Amitay Isaacs

Created: 2014-07-29 07:43:19 UTC

Size: 1.23 KB

patch

obsolete

>From 1d7e4df83a828694e9d6af5af0ffa1eb2c5f0425 Mon Sep 17 00:00:00 2001
>From: Amitay Isaacs <amitay@gmail.com>
>Date: Mon, 28 Jul 2014 13:07:58 +1000
>Subject: [PATCH 1/2] s4-rpc: dnsserver: Allow . to be specified for @ record
>
>Windows allow both . and @ to be specified with modifying @ record.
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=10742
>
>Signed-off-by: Amitay Isaacs <amitay@gmail.com>
>---
> source4/rpc_server/dnsserver/dcerpc_dnsserver.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c
>index f3dd195..856016c 100644
>--- a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c
>+++ b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c
>@@ -1859,7 +1859,9 @@ static WERROR dnsserver_update_record(struct dnsserver_state *dsstate,
> 	W_ERROR_HAVE_NO_MEMORY(tmp_ctx);
> 
> 	/* If node_name is @ or zone name, dns record is @ */
>-	if (strcmp(node_name, "@") == 0 || strcasecmp(node_name, z->name) == 0) {
>+	if (strcmp(node_name, "@") == 0 ||
>+	    strcmp(node_name, ".") == 0 ||
>+	    strcasecmp(node_name, z->name) == 0) {
> 		name = talloc_strdup(tmp_ctx, "@");
> 	} else {
> 		name = dns_split_node_name(tmp_ctx, node_name, z->name);
>-- 
>1.9.3
>

Flags:

amitay: review? (metze)

Actions: View

Attachments on bug 10742: 10155 | 10156 | 10157 | 10158