The Samba-Bugzilla – Attachment 10118 Details for
Bug 10469
Memory Leak In Main Process
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch for v4-0-test
tmp40.diff (text/plain), 1.58 KB, created by
Stefan Metzmacher
on 2014-07-17 07:58:13 UTC
(
hide
)
Description:
Patch for v4-0-test
Filename:
MIME Type:
Creator:
Stefan Metzmacher
Created:
2014-07-17 07:58:13 UTC
Size:
1.58 KB
patch
obsolete
>From 8414a036a3536c1607945c54bd723304945a431d Mon Sep 17 00:00:00 2001 >From: Stefan Metzmacher <metze@samba.org> >Date: Wed, 16 Jul 2014 16:17:56 +0200 >Subject: [PATCH] ldb-samba: fix a memory leak in > ldif_canonicalise_objectCategory() > >Searches for '(objectCategory=Person)' will leak a ldb_dn structure >on the ldb_context. These searches are typically used by Zarafa. > >Bug: https://bugzilla.samba.org/show_bug.cgi?id=10469 > >Signed-off-by: Stefan Metzmacher <metze@samba.org> >Reviewed-by: Volker Lendecke <vl@samba.org> > >Autobuild-User(master): Stefan Metzmacher <metze@samba.org> >Autobuild-Date(master): Thu Jul 17 00:51:57 CEST 2014 on sn-devel-104 > >(cherry picked from commit 8d33cddcb001a5a78aca036161d6223268274211) >--- > lib/ldb-samba/ldif_handlers.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/lib/ldb-samba/ldif_handlers.c b/lib/ldb-samba/ldif_handlers.c >index c7385f6..93cce29 100644 >--- a/lib/ldb-samba/ldif_handlers.c >+++ b/lib/ldb-samba/ldif_handlers.c >@@ -483,8 +483,13 @@ static int ldif_canonicalise_objectCategory(struct ldb_context *ldb, void *mem_c > const char *lDAPDisplayName = talloc_strndup(tmp_ctx, (char *)in->data, in->length); > sclass = dsdb_class_by_lDAPDisplayName(schema, lDAPDisplayName); > if (sclass) { >- struct ldb_dn *dn = ldb_dn_new(mem_ctx, ldb, >+ struct ldb_dn *dn = ldb_dn_new(tmp_ctx, ldb, > sclass->defaultObjectCategory); >+ if (dn == NULL) { >+ talloc_free(tmp_ctx); >+ return LDB_ERR_OPERATIONS_ERROR; >+ } >+ > *out = data_blob_string_const(ldb_dn_alloc_casefold(mem_ctx, dn)); > talloc_free(tmp_ctx); > >-- >1.9.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
vl
:
review+
Actions:
View
Attachments on
bug 10469
:
9993
|
9995
|
10117
| 10118