Attachment 10060 Details for Bug 10680 – patch

[patch] patch

10680.patch (text/plain), 995 bytes, created by Volker Lendecke on 2014-06-29 09:03:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2014-06-29 09:03:59 UTC

Size: 995 bytes

patch

obsolete

>From 4a349349feecf944d91f0e7b6e9661ba5d7429cf Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Sun, 29 Jun 2014 08:56:03 +0000
>Subject: [PATCH] smbstatus: Fix an uninitialized variable
>
>We only print valid share mode entries, stale ones don't count. In
>traverse, let the callback decide about staleness.
>
>https://bugzilla.samba.org/show_bug.cgi?id=10680
>
>Signed-off-by: Volker Lendecke <vl@samba.org>
>---
> source3/locking/share_mode_lock.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/source3/locking/share_mode_lock.c b/source3/locking/share_mode_lock.c
>index 6782f59..d9076db 100644
>--- a/source3/locking/share_mode_lock.c
>+++ b/source3/locking/share_mode_lock.c
>@@ -487,6 +487,7 @@ static int traverse_fn(struct db_record *rec, void *_state)
> 		return 0;
> 	}
> 	for (i=0; i<d->num_share_modes; i++) {
>+		d->share_modes[i].stale = false; /* [skip] in idl */
> 		state->fn(&d->share_modes[i],
> 			  d->servicepath, d->base_name,
> 			  state->private_data);
>-- 
>1.8.1.2
>

Flags:

obnox: review+

Actions: View

Attachments on bug 10680: 10060