The Samba-Bugzilla – Attachment 10006 Details for
Bug 10646
crash open_file_ntcreate: Frame not freed in order
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
4.1 patch cherry-picked from master
0001-Fix-several-talloc-stack-frames-not-freed.patch (text/plain), 3.31 KB, created by
Andrew Bartlett
on 2014-06-04 23:14:56 UTC
(
hide
)
Description:
4.1 patch cherry-picked from master
Filename:
MIME Type:
Creator:
Andrew Bartlett
Created:
2014-06-04 23:14:56 UTC
Size:
3.31 KB
patch
obsolete
>From 404849e8e72d8343fdd6cdac7fb83bdf2e289692 Mon Sep 17 00:00:00 2001 >From: Samuel Cabrero <scabrero@zentyal.com> >Date: Wed, 28 May 2014 17:57:31 +0200 >Subject: [PATCH] Fix several talloc stack frames not freed > >Signed-off-by: Samuel Cabrero <scabrero@zentyal.com> >Reviewed-by: Kamen Mazdrashki <kamenim@samba.org> >Reviewed-by: Andrew Bartlett <abartlet@samba.org> > >Autobuild-User(master): Kamen Mazdrashki <kamenim@samba.org> >Autobuild-Date(master): Fri May 30 15:29:29 CEST 2014 on sn-devel-104 > >(cherry picked from commit 90f9db9c062f2953c19f62dab3fab0b61d8c8e6c) >--- > source3/passdb/pdb_samba_dsdb.c | 8 ++++++++ > source4/torture/libnetapi/libnetapi.c | 1 + > 2 files changed, 9 insertions(+) > >diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c >index 3fc266c..aa04aa7 100644 >--- a/source3/passdb/pdb_samba_dsdb.c >+++ b/source3/passdb/pdb_samba_dsdb.c >@@ -339,6 +339,7 @@ static int pdb_samba_dsdb_replace_by_sam(struct pdb_samba_dsdb_state *state, > > msg = ldb_msg_new(frame); > if (!msg) { >+ talloc_free(frame); > return false; > } > >@@ -375,6 +376,7 @@ static int pdb_samba_dsdb_replace_by_sam(struct pdb_samba_dsdb_state *state, > pw, strlen(pw), > (void *)&pw_utf16.data, > &pw_utf16.length)) { >+ talloc_free(frame); > return LDB_ERR_OPERATIONS_ERROR; > } > ret |= ldb_msg_add_value(msg, "clearTextPassword", &pw_utf16, NULL); >@@ -1010,6 +1012,7 @@ static NTSTATUS pdb_samba_dsdb_getgrgid(struct pdb_methods *m, GROUP_MAP *map, > > status = idmap_xids_to_sids(state->idmap_ctx, tmp_ctx, id_maps); > if (!NT_STATUS_IS_OK(status)) { >+ talloc_free(tmp_ctx); > return status; > } > status = pdb_samba_dsdb_getgrsid(m, map, *id_map.sid); >@@ -1508,6 +1511,7 @@ static NTSTATUS pdb_samba_dsdb_delete_alias(struct pdb_methods *m, > > if (ldb_transaction_start(state->ldb) != LDB_SUCCESS) { > DEBUG(0, ("Failed to start transaction in dsdb_add_domain_alias(): %s\n", ldb_errstring(state->ldb))); >+ talloc_free(tmp_ctx); > return NT_STATUS_INTERNAL_ERROR; > } > >@@ -1529,15 +1533,18 @@ static NTSTATUS pdb_samba_dsdb_delete_alias(struct pdb_methods *m, > DEBUG(10, ("ldb_delete failed %s\n", > ldb_errstring(state->ldb))); > ldb_transaction_cancel(state->ldb); >+ talloc_free(tmp_ctx); > return NT_STATUS_LDAP(rc); > } > > if (ldb_transaction_commit(state->ldb) != LDB_SUCCESS) { > DEBUG(0, ("Failed to commit transaction in pdb_samba_dsdb_delete_alias(): %s\n", > ldb_errstring(state->ldb))); >+ talloc_free(tmp_ctx); > return NT_STATUS_INTERNAL_ERROR; > } > >+ talloc_free(tmp_ctx); > return NT_STATUS_OK; > } > >@@ -2044,6 +2051,7 @@ static bool pdb_samba_dsdb_gid_to_sid(struct pdb_methods *m, gid_t gid, > > status = idmap_xids_to_sids(state->idmap_ctx, tmp_ctx, id_maps); > if (!NT_STATUS_IS_OK(status)) { >+ talloc_free(tmp_ctx); > return false; > } > *sid = *id_map.sid; >diff --git a/source4/torture/libnetapi/libnetapi.c b/source4/torture/libnetapi/libnetapi.c >index c516976..431b531 100644 >--- a/source4/torture/libnetapi/libnetapi.c >+++ b/source4/torture/libnetapi/libnetapi.c >@@ -35,6 +35,7 @@ bool torture_libnetapi_init_context(struct torture_context *tctx, > > if (!lp_load(lpcfg_configfile(tctx->lp_ctx), true, false, false, true)) { > fprintf(stderr, "error loading %s\n", lpcfg_configfile(tctx->lp_ctx)); >+ talloc_free(frame); > return W_ERROR_V(WERR_GENERAL_FAILURE); > } > >-- >2.0.0.rc2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
kamenim
:
review+
Actions:
View
Attachments on
bug 10646
:
10001
|
10002
| 10006